This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix for cleos and keosd race condition - 2.0 #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were supposed to fix the problem of keosd auto-start by
cleos, which manifests itself in the following error message:
$ ./programs/cleos/cleos wallet list
.../programs/keosd/keosd" launched
Unable to connect to keosd, if keosd is running please kill the
...process and try again.
I cannot confirm that the fix works, but the patch from #8671 is applied
verbatim without conflicts.
spoonincode
approved these changes
May 8, 2020
There was a problem hiding this comment.
As far as I can tell indeed the patch from #8671 should be applied to 2.0. 2.0's http_plugin uses fc::thread_pool which is what caused the regression in the first place. It was probably oversight that this wasn't ported back to begin with (the original issue report explicitly called out develop which may have helped this fall through the cracks)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Port changes from PR #8671.
These changes were supposed to fix the problem of keosd auto-start by cleos, which manifests itself in the following error message:
I cannot confirm that the fix works, but the patch from #8671 is applied verbatim without conflicts.
Consensus Changes
API Changes
Documentation Additions