This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add cleos --compression option for transactions #9050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe-b1
approved these changes
May 6, 2020
| @@ -209,6 +227,8 @@ void add_standard_transaction_options(CLI::App* cmd, string default_permission = | |||
| cmd->add_flag("--return-packed", tx_return_packed, localized("Used in conjunction with --dont-broadcast to get the packed transaction")); | |||
| cmd->add_option("-r,--ref-block", tx_ref_block_num_or_id, (localized("Set the reference block num or block id used for TAPOS (Transaction as Proof-of-Stake)"))); | |||
| cmd->add_flag("--use-old-rpc", tx_use_old_rpc, localized("Use old RPC push_transaction, rather than new RPC send_transaction")); | |||
| cmd->add_option("--compression", tx_compression, localized("Compression for transaction 'none' or 'zlib'"))->transform( | |||
There was a problem hiding this comment.
Maybe also list the defaults somewhere.
There was a problem hiding this comment.
--compression ENUM:value in {none->0,zlib->1} OR {0,1}
Compression for transaction 'none' or 'zlib'
There was a problem hiding this comment.
Not really sure I like the output of CLI11 for this, but I guess it is fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
--compressionoption tocleosConsensus Changes
API Changes
Documentation Additions
New option for transactions in cleos
--compression. Can be eitherzlibornone. The defaults for all transactions has not changed.set contract,set code, &set abidefault iszlib, all other transaction types the default isnone.