This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix keosd auto-launching after CLI11 upgrade - 2.0 #9028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, CLI11 introduced different types of callbacks: preparse_callback(), parse_complete_callback(), final_callback(). The CLI::App::callback() method now maps to final_callback() by default. In cleos, one of the callbacks (namely, ensure_keosd_running()), needs to be called immediately after option parsing is done -- thus, this fix.
heifner
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replica of #9025 for
release/2.0.x.Change Description
At some point, CLI11 introduced different types of callbacks:
preparse_callback(),parse_complete_callback(),final_callback().The
CLI::App::callback()method now maps tofinal_callback()by default.In
cleos, one of the callbacks (namely,ensure_keosd_running()), needs to be called immediately after option parsing is done – thus, this fix.Consensus Changes
API Changes
Documentation Additions