This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Bring back CLI11 1.9.0 - develop #9016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes #8947 by upgrading CLI11 to the latest version.
As outlined on https://github.com/CLIUtils/CLI11, filesystem library is separate from the standard library on GCC 8. CLI11 uses the filesystem library only for the path type checks, which are not used by cleos, so it's safe to switch to the fallback implementation provided by CLI11.
cleos does not make use of the functionality provided by <filesystem> in CLI11, so it makes sense to disable it for all platforms to simplify the configuration.
This script tests that 'nodeos --help' and 'cleos --help' work.
This commit restored backward compatibility with older version of CLI11, which allowed option arguments to be omitted. Cleos relies on this behavior to read passwords and private keys from stdin when they're not specified on the command line.
heifner
approved these changes
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This pull request brings back the series of commits that upgrade CLI11 to the latest version 1.9.0. It was initially created in #8960 and then reverted in #9011 due to the test flakiness in order to clear the way for the release.
This fixes #8947
Consensus Changes
API Changes
Documentation Additions