Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Support Running ALL Tests in One Build #8968

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Conversation

kj4ezj
Copy link
Contributor

@kj4ezj kj4ezj commented Apr 17, 2020

Change Description

This pull request enables engineers to start a build with RUN_ALL_TESTS set to true to run ALL tests in the CICD pipeline, for example, to include the time-consuming post-merge checks on a pre-merge build.

Pinned and unpinned builds and tests must still be done in separate builds due to step (AKA Buildkite job) name collisions. This is possible to do, but the cost and risk of changing the step names and updating the infrastructure built around them is not worth the tradeoff, as we have learned in the past.

Tested Working

Some builds show the pipeline step generation and then were cancelled so as not to waste agents, while other builds show pipeline step generation and passing tests.

See Also

Consensus Changes

  • Consensus Changes
    None.

API Changes

  • API Changes
    None.

Documentation Additions

  • Documentation Additions
    None.

@kj4ezj kj4ezj changed the base branch from master to release/2.0.x April 17, 2020 15:40
@kj4ezj kj4ezj marked this pull request as ready for review April 20, 2020 15:28
@kj4ezj kj4ezj requested review from scottarnette and arhag April 20, 2020 15:28
Copy link
Contributor

@scottarnette scottarnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants