This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Replace bc with shell arithmetic - 2.0 #8949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge release 2.0.4 to master
The variable MEM_GIG was computed using bc, an arbitrary precision calculator. That caused a numeric comparison that used that variable in scripts/eosio_build_darwin.sh to fail when the scale was set to a value greater than zero in the user's ~/.bc configuration file. This commit fixes the problem by switching to shell arithmetic when computing MEM_GIG.
|
seems good to me |
heifner
approved these changes
Apr 16, 2020
scottarnette
approved these changes
Apr 16, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The variable
MEM_GIGwas computed usingbc, an arbitrary precision calculator. That caused a numeric comparison that used that variable inscripts/eosio_build_darwin.shto fail when the scale was set to a value greater than zero in the user's~/.bcconfiguration file.This commit fixes the problem by switching to shell arithmetic when computing
MEM_GIG.Consensus Changes
API Changes
Documentation Additions