This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
trace_api_plugin yield timeout - 2.0 #8826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug log for all fc::exceptions. Provide access to max-response-time-ms setting.
b1bart
approved these changes
Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
trace_api_pluginnow honorshttp-max-response-time-msas a specification of retrieval and ABI processing time.http-max-response-time-msis also the time allowed forhttp_pluginconversion to JSON. Maximum time allowed fortrace_api_pluginget_blocknow has approximately 2xhttp-max-response-time-ms. It is very likely that http-max-response-time-ms will need to be increased from the default.http_pluginlogging to not error log ontimeout_exception.http_pluginurl_handlersohttp-max-response-mscan be used as a specification of complete time allowed for api calls e.g.get_table_rowsallowing the removal of hard-coded 10ms limit.Consensus Changes
API Changes
Documentation Additions