This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
(appbase sync) Provide a version string based off "git describe" #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appbase will now provide a version string that is based off "git describe --tags --dirty". This provides a readable version number like v1.1.0 as well as information on intermediate git revisions and/or dirtiness. Since we don’t provide eosio as a .tar.gz package due to Github’s lack of submodules on tarballing, generally all users should be building in a git clone. Be aware this change will run git describe on EVERY build. The command is quite fast (around 100ms even on a slower 2017 MacBook, but sub 30ms on a quality Linux dev box) and will hopefully provide enough benefit to be worth it.
heifner
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appbase will now provide a version string that is based off "git describe --tags --dirty". This provides a readable version number like v1.1.0 as well as information on intermediate git revisions and/or dirtiness. Since we don’t provide eosio as a .tar.gz package due to Github’s lack of submodules on tarballing, generally all users should be building in a git clone.
Be aware this change will run git describe on EVERY build. The command is quite fast (around 100ms even on a slower 2017 MacBook, but sub 30ms on a quality Linux dev box) and will hopefully provide enough benefit to be worth it.