Free allocated memory in unpack_action_data #4960
Conversation
contracts/eosiolib/action.hpp
Outdated
| @@ -50,7 +50,11 @@ namespace eosio { | |||
| size_t size = action_data_size(); | |||
| char* buffer = (char*)( max_stack_buffer_size < size ? malloc(size) : alloca(size) ); | |||
There was a problem hiding this comment.
Add:
const bool heap_allocation = max_stack_buffer_size < size;
and use heap_allocation in both places.
There was a problem hiding this comment.
Thanks for the suggestion. It makes it clearer to read :)
I've updated the PR
|
@andriantolie I fail to see how this would have anything to do with "env.free unresolveable". Where you able to reproduce the "env.free unresolveable" error? And if so, did this fix it? |
|
Yes, this actually doesn't really solve "env.free unresolvable" entirely. But this just solves the "env.free unresolvable" problem when people creates a simple contract with just unpack_action_data. I couldn't figure out the reasoning behind this. But seems people get "env.free unresolvable" error when they include string object inside his action struct, but never called "free" function anywhere in the contract. That's why when people use EOSIO_ABI, or when they call "free" function at least once in the contract, they don't get the error. In the .wast file, the "free" function turns from "import" to "export" when it is being used in the contract. I don't have sufficient knowledge to understand the reasoning behind this though, so if somebody can explain I'm really happy to learn.... |
|
@larryk85 @spoonincode Is there someway we can tell wast to export instead of import to solve this unresolvable error without having to actually call free? The memory will all be free'd at the end of the action, so seems like a waste to free when it is not necessary. |
Looking at issue #4930 in these past days, I notice some people are still using
unpack_action_datainstead ofEOSIO_ABI.When using
unpack_action_dataand their action structure contains string, it will throw "env.free unresolveable" when uploading the contract. I guess it's not linked with thefreedefined in eosiolib.cpp?