Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Enable multi-threading when building boost libraries #4870

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Enable multi-threading when building boost libraries #4870

merged 1 commit into from
Aug 3, 2018

Conversation

baegjae
Copy link
Contributor

@baegjae baegjae commented Jul 26, 2018

When I ran eosio_build.sh, it takes too long time.
The cause was that only one thread is used when building the boost libraries.
I modified the script to use multiple threads.
Our time is precious :)

@heifner
Copy link
Contributor

heifner commented Jul 30, 2018

@jgiszczak What are your thoughts on this? Do you think it will cause more support requests than it is worth? Also it should be JOBS not CPU_CORE, I assume.

@heifner heifner requested a review from jgiszczak July 30, 2018 14:46
@heifner heifner changed the base branch from master to develop July 30, 2018 14:46
ghost
ghost approved these changes Jul 30, 2018
@baegjae
Copy link
Contributor Author

baegjae commented Jul 31, 2018

@lazaridiscom, Thank you for your comment. When building the MongoDB driver, CPU_CORE was used as an argument within the build-scripts. Likewise, I thought CPU_CORE should be used when building the boost libraries.

@heifner
Copy link
Contributor

heifner commented Jul 31, 2018

See #4920. I think we should pass jobs # to the build script defaulted to 1. That would help with the build problems where people don't have enough ram. Let the user indicate how many cores they want to throw at it.

@heifner heifner merged commit 5018599 into EOSIO:develop Aug 3, 2018
@baegjae baegjae deleted the enable-multithread-boost branch August 6, 2018 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants