Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

replace is_callable_v workaround with is_invocable_v in eos-vm; fixes clang12 build #10420

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

spoonincode
Copy link
Contributor

Change Description

This is_callable_v workaround in eos-vm for some old compiler is causing compile failures on clang12 with the error

template argument for non-type template parameter must be an expression

Replacing the workaround with simply is_invocable_v seems to work on clang12, our entire CICD collection, and gcc8, clang6, and XCode 10.2 (the latter of which doesn't actually build the entirety of eosio develop anyways). Please review carefully though I may be misunderstanding what is going on here.

Needs EOSIO/eos-vm#210 and seems to pick up EOSIO/eos-vm#209 which hasn't been synced up here.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant