This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
replace is_callable_v workaround with is_invocable_v in eos-vm; fixes clang12 build #10420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This
is_callable_v
workaround in eos-vm for some old compiler is causing compile failures on clang12 with the errorReplacing the workaround with simply
is_invocable_v
seems to work on clang12, our entire CICD collection, and gcc8, clang6, and XCode 10.2 (the latter of which doesn't actually build the entirety of eosio develop anyways). Please review carefully though I may be misunderstanding what is going on here.Needs EOSIO/eos-vm#210 and seems to pick up EOSIO/eos-vm#209 which hasn't been synced up here.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions