Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docs for vector migration by genetics changes. #9

Merged

Conversation

stitova-idm
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Bridenbecker Bridenbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being so disciplined to update the documentation

docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-vector.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@Bridenbecker Bridenbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being on top of updating the documentation. I'm bad at it.

I have some recommendations, but maybe we should see if Ross can look at it too before you do anything. You might see if you can have a meeting with him so you can discuss it (and my comments) live.

docs/emod/software-migration-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@Bridenbecker Bridenbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Just need to be able to call the CSV to binary from the package

docs/emod/software-migration-creation-vector.rst Outdated Show resolved Hide resolved
…s, we will eventually be importing them from the migration file, but they aren't there yet.
Copy link
Collaborator

@Bridenbecker Bridenbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stitova-idm stitova-idm merged commit e4fe47c into EMOD-Hub:main Dec 18, 2024
3 checks passed
@stitova-idm stitova-idm deleted the updates_for_VECTOR_MIGRATION_BY_GENETICS branch December 19, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants