Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for username/password for sparqlwrapper #308

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jan 14, 2025

Description

Added support for username/password for sparqlwrapper.

A CI test would require an online triplestore to test against. Therefore not added. However, the following seems to work:

from tripper import Triplestore

ts = Triplestore("sparqlwrapper", base_iri="https://graphdb.pink-project.eu/repositories/playground", username="USER", password="XXX")
print(list(ts.triples))

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.85%. Comparing base (c1e8213) to head (b105b37).

Files with missing lines Patch % Lines
tripper/backends/sparqlwrapper.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   76.87%   76.85%   -0.03%     
==========================================
  Files          22       22              
  Lines        2465     2467       +2     
==========================================
+ Hits         1895     1896       +1     
- Misses        570      571       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis mentioned this pull request Jan 15, 2025
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant