-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command-line datadoc script #281
Conversation
- Allow to add other types of entries to the triplestore that are not datasets. Ex: samples, models, instruments, people, projects... - Renamed list_data_iris() to search_iris(). It can now be use to search for all types of entries. - Renamed prepare() to as_jsonld() and made it part of the public API
For more information, see https://pre-commit.ci
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 79.18% 76.68% -2.50%
==========================================
Files 21 22 +1
Lines 2263 2415 +152
==========================================
+ Hits 1792 1852 +60
- Misses 471 563 +92 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
I find the way of calling the CLI here to be a bit unconventional.
For instance, to find something, I have to parse before running find:
datadoc --parse="kb.ttl" find
Should we instead have
datadoc find --parse="kb.ttl"
The parse keyboard could also be set as required/positional for datadoc find I think.
], | ||
|
||
# Documenting of the resource using keywords defined in the context | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... | |
# ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is documentation that is not checked with doctext, so I think it is fine to keep the ellipsis. Changing from json to python removes the strict syntax checking on github
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Description
Added a new command-line tool for data documentation and documented it.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.