Added csv parser to Tabledoc #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow to add other types of entries to the triplestore that are not
datasets. Ex: samples, models, instruments, people, projects...
- Renamed list_data_iris() to search_iris(). It can now be use to search
for all types of entries.
- Renamed prepare() to as_jsonld() and made it part of the public API
For more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 78.46% 78.66% +0.20%
==========================================
Files 21 21
Lines 2206 2222 +16
==========================================
+ Hits 1731 1748 +17
+ Misses 475 474 -1 ☔ View full report in Codecov by Sentry. |
torhaugl
approved these changes
Dec 19, 2024
torhaugl
requested changes
Dec 19, 2024
tests/dataset/test_tabledoc.py
Outdated
Comment on lines
84
to
86
| # if True: | ||
| def test_parse_csv(): | ||
| """Test parsing a csv file.""" |
There was a problem hiding this comment.
The output of this tests seems wrong?
@prefix dcat: <http://www.w3.org/ns/dcat#> .
@prefix emmo: <https://w3id.org/emmo#> .
<https://he-matchmaker.eu/data/sem/SEM_cement_batch2> a dcat:Dataset,
emmo:EMMO_194e367c_9783_4bf5_96d0_9ad597d48d9a .
<https://he-matchmaker.eu/data/sem/SEM_cement_batch2/77600-23-001> a dcat:Dataset,
emmo:EMMO_194e367c_9783_4bf5_96d0_9ad597d48d9a .
<https://he-matchmaker.eu/data/sem/SEM_cement_batch2/77600-23-001/77600-23-001_5kV_400x_m001> a dcat:Dataset,
emmo:EMMO_194e367c_9783_4bf5_96d0_9ad597d48d9a .
<https://he-matchmaker.eu/sample/SEM_cement_batch2/77600-23-001> a dcat:Dataset,
emmo:EMMO_194e367c_9783_4bf5_96d0_9ad597d48d9a .
There was a problem hiding this comment.
The output of this tests seems wrong?
Well spottet! It is corrected now.
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added csv parser to Tabledoc (using the built-in csv module).
Note: This PR builds on top of PR #273
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.