Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify excel parse #46

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Modify excel parse #46

merged 6 commits into from
Apr 8, 2022

Conversation

daniel-sintef
Copy link
Contributor

@daniel-sintef daniel-sintef commented Apr 7, 2022

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #46 (5d71a07) into master (2a2f7ed) will decrease coverage by 1.23%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   89.16%   87.92%   -1.24%     
==========================================
  Files          10       10              
  Lines         203      207       +4     
==========================================
+ Hits          181      182       +1     
- Misses         22       25       +3     
Flag Coverage Δ
linux 87.92% <33.33%> (-1.24%) ⬇️
windows 87.74% <33.33%> (-1.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oteapi_dlite/strategies/parse_excel.py 87.83% <33.33%> (-3.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2f7ed...5d71a07. Read the comment docs.

@daniel-sintef daniel-sintef requested review from kriwiik and removed request for jesper-friis April 8, 2022 08:04
Copy link

@kriwiik kriwiik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@daniel-sintef daniel-sintef merged commit 57bf366 into master Apr 8, 2022
@daniel-sintef daniel-sintef deleted the modify_excel_parse branch April 8, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants