Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate docs build #257

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Consolidate docs build #257

merged 2 commits into from
Jul 4, 2024

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Jul 4, 2024

Description:

Ensure the setup for building documentation (including the Python API and fixing the landing page) is the same in the CI/CD as it is for the pre-commit hook.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@CasperWA CasperWA requested a review from francescalb July 4, 2024 08:01
francescalb
francescalb approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, thank you.

@CasperWA CasperWA merged commit 4511b21 into master Jul 4, 2024
11 checks passed
@CasperWA CasperWA deleted the cwa/consolidate-docs-build branch July 4, 2024 08:08
Treesarj pushed a commit to SINTEF/oteapi-dlite-Mod that referenced this pull request Aug 28, 2024
@CasperWA @Treesarj
Consolidate docs build (EMMC-ASBL#257)
c6cf018 
Update CI/CD workflows to match pre-commit hooks
This is relevant only for building and testing the documentation.

Update documentation according to specific setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CasperWA @francescalb