Delete permission by #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infa-rvarahag
requested changes
Nov 11, 2024
| private Response deletePermissionById(int createdId) { | ||
| try { | ||
| deletePermissionEndpoint = new URI(PROP_LIST.get("scp.delete.permission.endpoint").toString() + createdId); |
There was a problem hiding this comment.
use built in method get URI.
createrId should be passed in response avoid string concatenation
| try { | ||
| // Construct the endpoint URI | ||
| listPermissionsByRoleEndpoint = new URI(PROP_LIST.get("scp.qa.listPermissionByRole.endpoint").toString()); |
There was a problem hiding this comment.
same comments here, use built in method
| response.prettyPrint(); | ||
|
|
||
| // Validate response code is 200 for a successful deletion | ||
| Assert.assertEquals(statusCode, 202, "Status code should be 200 for successful deletion"); |
There was a problem hiding this comment.
message expecting 200 , but code looking for 202
| logger.info("Started calling the GetListPermissionsByRole API with a valid role."); | ||
|
|
||
| // Call getListPermissionsByRole with a specific role | ||
| Response response = getListPermissionsByRole("admin"); // Replace "admin" with the actual role to test |
There was a problem hiding this comment.
Do we have role called "admin" ?
if hardcode like this, how it will run in prod .
Just see how we can achieve in all the environments
| logger.info("Received expected error for invalid token."); | ||
| } | ||
| @Test(priority = 9 , description = "Verifies the functionality of deleting user's permission by ID.") | ||
| public void testDeletePermissionById() { |
There was a problem hiding this comment.
can you run this test method alone ?
this method should depend on testCreatePermissionWithValidPayload()
Check once .
infa-rvarahag
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.