If Mail Account has empty password, it's still regarded as imap #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbecker
reviewed
Feb 28, 2017
api/src/Mail/Account.php
Outdated
| @@ -397,7 +397,7 @@ public function imapServer($_adminConnection=false, $_timeout=null) | |||
| */ | |||
| public function is_imap($try_connect=true) | |||
| { | |||
| if (empty($this->acc_imap_host) || empty($this->acc_imap_username) || empty($this->acc_imap_password)) | |||
| if (empty($this->acc_imap_host) && empty($this->acc_imap_username) && empty($this->acc_imap_password)) | |||
| { | |||
There was a problem hiding this comment.
That goes to far, empty host makes not sense!
if (empty($this->acc_imap_host) || empty($this->acc_imap_username) && empty($this->acc_imap_password))
Thought these kind of changes tend to break working installations ...
ralfbecker
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if a mail account has no password, it fails to be recognized as a valid imap account.
This creates issues if one tries to edit this account later. Since it's not recognized as a imap account, the wizard prompts the user to create a new account, and not edit the existing one.