-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store some additional tracker data in tracking_map #2839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than full domains.
Require "action_map" and "snitch_map" keys, ignore everything else. If those keys are present, it's probably a Privacy Badger user data file. Any other keys will be either ignored or correctly processed when merging.
Also, here is a recent 20K site Chrome run with blocking disabled ( Useful console queries: Prints the ten most prevalent tracker base domains along with their prevalence (how many site base domains they were seen on): let sm = badger.storage.snitch_map;
Object.keys(sm._store).map(d => [d, sm._store[d].length]).sort((a, b) => b[1] - a[1]).slice(0, 10).reduce((memo, i) => { memo.push(i[0] + ": " + i[1]); return memo; }, []) Prints the most prevalent canvas fingerprinters: let tm = badger.storage.tracking_map;
Object.keys(tm._store).filter(d => Object.keys(tm._store[d]).some(s => tm._store[d][s].includes("canvas"))).map(d => [d, Object.keys(tm._store[d]).length]).sort((a, b) => b[1] - a[1]).slice(0, 25).reduce((memo, i) => { memo.push(i[0] + ": " + i[1]); return memo; }, []) |
ghostwords
added
the
heuristic
Badger's core learning-what-to-block functionality
label
Apr 27, 2022
ghostwords
added a commit
to EFForg/badger-sett
that referenced
this pull request
May 20, 2022
Ran into this issue with a 100K site no-blocking mode scan during the merge step. Following up on Badger Sett's --no-blocking mode and EFForg/privacybadger#2839
ghostwords
added a commit
that referenced
this pull request
Apr 18, 2023
To prefer entries that also exist in snitch_map. Following up on #2839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
tracking_map
, a new Badger storage area. It is similar tosnitch_map
, but instead of tracker base domains pointing to arrays of site base domains, tracker base domains point to objects keyed by site base domains with arrays of detected tracking types for values. For example:For now, just two tracking types are being tracked:
"canvas"
(fingerprinting) and"pixelcookieshare"
.Here is a recent 20K site Chrome run: results.zip. Let's compare this/bigger scans to Disconnect's
FingerprintingInvasive
domains and Tracker Radar fingerprinters.Should help with #1527 by at least helping us understand the extent of the problem.
Could be followed up by calling out domains that engage in particularly invasive tracking (such as canvas fingeprinting) in the UI (related to #963).
Replaces https://github.com/EFForg/privacybadger/tree/explain-blocking.