This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Update Cipher List for Pending Fetch Test #18964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TLS 1.2
|
The current versions of ESR/Tor are still supporting TLS 1.0, 3DES an CBC ciphers. |
|
@J0WI We need to test for intersection of supported browsers' cipher lists, so even if only Chrome removed TLS 1.0, 3DES or CBC ciphers, we would have to disable it anyway. |
|
@J0WI Should we replicate this behavior by making a connection without 3DES support and if if fails, making another with 3DES support enabled? |
|
I think we should just keep it in the cipher list until it's disabled by default in browsers. |
pipboy96
suggested changes
Mar 4, 2020
6 tasks
zoracon
added a commit
that referenced
this pull request
Mar 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating cipher suite to TLS 1.2 for March Fetch Test
TLS 1.0., 1.1 complete deprecation in both Chrome and Firefox roll out in March
Related PR:
#18700
Related Issue:
#18866