[WIP] FieldReduction.H : make volume calculation more compact using std::reduce over dx vector #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
reviewed
Feb 20, 2025
| // If reduction operation is a sum, multiply the value by the cell volume so that the | ||
| // result is the integral of the function over the simulation domain. | ||
| const auto cell_volume = std::reduce(std::begin(dx), std::end(dx), 1.0_rt, std::multiplies<>()); | ||
| reduce_value *= cell_volume; | ||
| } |
There was a problem hiding this comment.
I've done things like this, which is also compact
reduce_value *= AMREX_D_TERM(dx[0], *dx[1], *dx[2]);
In fact, I already make this change in PR #5189.
There was a problem hiding this comment.
Oh, I see... sorry! Then, this PR has no reason to exist. I will close it immediately!
|
@lucafedeli88 This PR could submit the small change. This would help reduce the size of PR #5189 a little, as it is a very large PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the calculation of the
cell_volumehere more readable.