[WIP] Remove temporary particle container

[EZoni]

Close #5056.

[EZoni]

@atmyers

The test test_2d_laser_acceleration_boosted is one where I still see a segfault, which points to some discrepancy between source and destination runtime components:

terminate called after throwing an instance of 'std::runtime_error'
  what():  Assertion `dst.m_num_runtime_real == src.m_num_runtime_real' failed, file "/home/edoardo/src/warpx/build/_deps/fetchedamrex-src/Src/Particle/AMReX_ParticleTransformation.H", line 35

It seems to originate from particle filtering whithin BackTransformParticleFunctor::operator (). I have not figured out yet the bug in my changes.

[atmyers]

Note - we need this AMReX PR for this to work: https://github.com/AMReX-Codes/amrex/pull/4333/files

[EZoni]

Note - we need this AMReX PR for this to work: https://github.com/AMReX-Codes/amrex/pull/4333/files

Thanks for the bug fix! We can proceed here further after #5669 is merged.

[ax3l]

Needs AMReX-Codes/amrex#4341

[ax3l]

Great, only these tests still fail.

RZ

 11 - test_rz_electrostatic_sphere.checksum (Failed)
 38 - test_rz_flux_injection.analysis (Failed)
 39 - test_rz_flux_injection.checksum (Failed)
 42 - test_rz_flux_injection_from_eb.analysis (Failed)
 43 - test_rz_flux_injection_from_eb.checksum (Failed)
 46 - test_rz_langmuir_multi.analysis (Failed)
 47 - test_rz_langmuir_multi.checksum (Failed)
 50 - test_rz_langmuir_multi_picmi.checksum (Failed)
 53 - test_rz_langmuir_multi_psatd.analysis (Failed)
 54 - test_rz_langmuir_multi_psatd.checksum (Failed)
 57 - test_rz_langmuir_multi_psatd_current_correction.analysis (Failed)
 58 - test_rz_langmuir_multi_psatd_current_correction.checksum (Failed)
 61 - test_rz_langmuir_multi_psatd_multiJ.analysis (Failed)
 62 - test_rz_langmuir_multi_psatd_multiJ.checksum (Failed)
 82 - test_rz_load_external_field_grid.checksum (Failed)
 86 - test_rz_load_external_field_grid_restart.checksum (Failed)
 90 - test_rz_load_external_field_particles.checksum (Failed)
 94 - test_rz_load_external_field_particles_restart.checksum (Failed)
101 - test_rz_galilean_psatd.checksum (Failed)
105 - test_rz_galilean_psatd_current_correction.checksum (Failed)
109 - test_rz_galilean_psatd_current_correction_psb.checksum (Failed)
112 - test_rz_multiJ_psatd.checksum (Failed)
115 - test_rz_deuterium_tritium_fusion.analysis (Failed)
116 - test_rz_deuterium_tritium_fusion.checksum (Failed)
119 - test_rz_ohm_solver_cylinder_compression_picmi.checksum (Failed)
123 - test_rz_ohm_solver_em_modes_picmi.checksum (Failed)
134 - test_rz_point_of_contact_eb.analysis (Failed)
147 - test_rz_scraping.checksum (Failed)
151 - test_rz_scraping_filter.checksum (Failed)
158 - test_rz_laser_acceleration.checksum (Failed)
165 - test_rz_laser_acceleration_picmi.checksum (Failed)

3D

• test_3d_point_of_contact_eb.analysis

[atmyers]

Now we are down to:

test_rz_point_of_contact_eb.analysis
test_3d_point_of_contact_eb.analysis