Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing asserts now that AMReX has been updated. #5476

Conversation

clarkse
Copy link
Member

@clarkse clarkse commented Nov 20, 2024

AMReX-Codes/amrex#4226 fixes the issue that the asserts protected against. They have been removed.

This should close out #5444

Signed-off-by: S. Eric Clark <25495882+clarkse@users.noreply.github.com>
Copy link
Member

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @clarkse!
Once #5474 is merged we can rebase and merge.

@roelof-groenewald roelof-groenewald linked an issue Nov 21, 2024 that may be closed by this pull request
@roelof-groenewald roelof-groenewald self-assigned this Nov 21, 2024
@EZoni
Copy link
Member

EZoni commented Dec 6, 2024

@clarkse

Thanks for cleaning this up! #5474 is merged now, so we would need to rebase on development, as suggested by @roelof-groenewald. Do you want to do that or shall @roelof-groenewald or I go ahead and finalize this PR?

Copy link
Member

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clarkse!

@roelof-groenewald roelof-groenewald enabled auto-merge (squash) December 10, 2024 19:23
@roelof-groenewald roelof-groenewald merged commit 9fdee34 into ECP-WarpX:development Dec 10, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with magnetostatic solver test input file
3 participants