Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a RZ version for the test "Point_of_contact_EB" #4699

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Adding a RZ version for the test "Point_of_contact_EB" #4699

merged 3 commits into from
Feb 16, 2024

Conversation

EyaDammak
Copy link
Member

@EyaDammak EyaDammak commented Feb 15, 2024 •
edited by RemiLehe
Loading

This PR extends the tests of #4560 in RZ

RemiLehe
RemiLehe approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@RemiLehe RemiLehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot for this PR!

@RemiLehe RemiLehe merged commit e038ef9 into ECP-WarpX:development Feb 16, 2024
41 checks passed
@ax3l ax3l added geometry: RZ axisymmetric 2D and quasi-3D component: boundary PML, embedded boundaries, et al. labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiLehe RemiLehe RemiLehe approved these changes

Assignees
No one assigned
Labels
component: boundary PML, embedded boundaries, et al. geometry: RZ axisymmetric 2D and quasi-3D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EyaDammak @RemiLehe @ax3l