Load balancing bug fix: remake MultiFabs for Vay deposition, current centering, time averaging #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Thank you, @RevathiJambunathan and @hklion, for this bug fix! Looks good to me.
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Nov 22, 2022
…centering, time averaging (ECP-WarpX#3508) Additional MultiFabs for Vay deposition, current centering, and time averaging need to be allocated after load-balancing, otherwise the simulation crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional MultiFabs for
need to be allocated after load-balancing, otherwise the simulation crashes.
Thanks to @hklion for reporting this and testing it as well.