Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD #3424

RTSandberg · 2022-09-22T22:03:58Z

This PR prints when writing BTD data:

--- INFO    : Writing buffer 1 of 4 to openPMD BTD file lab_diags0

and

STEP 526 starts ...
--- INFO    : Writing buffer 4 of 4 to openPMD BTD file lab_diags9
--- INFO    : Finished writing openPMD BTD file lab_diags9

It raises a low priority warning if some BTD snapshots aren't expected to fill:

*     This simulation might not run long enough to fill all BTD  snapshots.
*     Final step: 2
*     Last BTD snapshot fills around step: 527
*     @ Raised by: ALL

Also, currently WarpX prints a notice to stdout when saving plotfile and checkpoints. This PR extends this notice to openPMD, Ascent, and Sensei formatted diagnostics

For example,

--- INFO    : Writing openPMD file boosted_diags000070
STEP 70 ends. TIME = 7.829116496e-14 DT = 1.118445214e-15

or

--- INFO    : Writing openPMD file lab_diags000000
STEP 255 ends. TIME = 2.852035295e-13 DT = 1.118445214e-15
Evolve time = 63.00286442 s; This step = 0.207136209 s; Avg. per step = 0.2470700565 s

CI test LaserAccelerationBoost now uses BTD for its checksums, as planned to improve CI coverage of BTD (see #3300).

EZoni · 2022-09-28T18:05:56Z

The PR looks good to me, but there's a couple of CI tests that fail with the following error:

No protocol specified                                                                                                                       
terminate called after throwing an instance of 'std::__ios_failure'             
what():  basic_ios::clear: iostream error                                     
SIGABRT

The tests that fail are RigidInjection_BTD and BTD_ReducedSliceDiag.
I do not understand yet why this happens, needs to be investigated more.

EZoni

Thank you for this PR, @RTSandberg! Besides my initial comment on the CI tests, I left a few minor suggestions.

Source/Diagnostics/FlushFormats/FlushFormatAscent.cpp

Source/Diagnostics/FlushFormats/FlushFormatOpenPMD.cpp

Source/Diagnostics/FlushFormats/FlushFormatPlotfile.cpp

Source/Diagnostics/FlushFormats/FlushFormatSensei.cpp

Source/Diagnostics/FlushFormats/FlushFormatAscent.cpp

Source/Diagnostics/FlushFormats/FlushFormatSensei.cpp

Regression/WarpX-tests.ini

Examples/Physics_applications/laser_acceleration/inputs_2d_boost

EZoni

Thank you for this PR, @RTSandberg! Looks great to me. I left a few minor comments.

Source/Diagnostics/BTD_Plotfile_Header_Impl.cpp

Source/Diagnostics/BTDiagnostics.cpp

EZoni

Thank you for the latest changes, @RTSandberg! Looks good to me. Will request a last review from @ax3l and then we can merge this.

EZoni · 2022-10-21T15:49:14Z

@ax3l Hi, just pinging in case you have any suggestions before I merge this PR.

Source/Diagnostics/BTDiagnostics.cpp

ax3l · 2022-10-24T22:31:42Z

Source/Diagnostics/BTDiagnostics.cpp

+    // j >= i / gamma / (1+beta) * dt_snapshot / dt_boosted_frame
+    const int final_snapshot_starting_step = ceil(final_snapshot_iteration / warpx.gamma_boost / (1._rt+warpx.beta_boost) * m_dt_snapshots_lab / dt_boosted_frame);
+    const int final_snapshot_fill_iteration = final_snapshot_starting_step + num_buffers * m_buffer_size - 1;
+    if (final_snapshot_fill_iteration > warpx.maxStep()) {


cc @RevathiJambunathan fyi what we discussed today

for more information, see https://pre-commit.ci

Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>

for more information, see https://pre-commit.ci

…e/openPMD (ECP-WarpX#3424) * print when writing openPMD, Ascent, Sensei * remove unnecesssary variables, include min_digits * print snapshot id when writing btd * fix ascent print * compile without warnings * still working on Ascent * still working Ascent * Print when BTD buffer is flushed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * print when writing openPMD, Ascent, Sensei * remove unnecesssary variables, include min_digits * print snapshot id when writing btd * fix ascent print * compile without warnings * still working on Ascent * still working Ascent * Print when BTD buffer is flushed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add warning message if BTD not full * adjust for CI, no in-situ vis BTD * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert to correct plotfile naming * change warning topic to BTD * nicer format for print statements * extend examples to fill BTD * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Reset Checksums of BTD_ReducedSliceDiag * Upgrade CI Test LaserAccelerationBoost * Apply suggestions from code review Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com> * improve BTD warning notes * edit final step notes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix formatting Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Edoardo Zoni <ezoni@lbl.gov> Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com> Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

EZoni self-assigned this Sep 23, 2022

EZoni added the component: diagnostics all types of outputs label Sep 23, 2022

EZoni self-requested a review September 23, 2022 21:10

RTSandberg changed the title ~~print when writing openPMD, Ascent, Sensei~~ [WIP] print when writing openPMD, Ascent, Sensei Sep 27, 2022

EZoni requested changes Sep 28, 2022

View reviewed changes

ax3l reviewed Oct 2, 2022

View reviewed changes

Source/Diagnostics/FlushFormats/FlushFormatAscent.cpp Outdated Show resolved Hide resolved

ax3l reviewed Oct 2, 2022

View reviewed changes

Source/Diagnostics/FlushFormats/FlushFormatSensei.cpp Show resolved Hide resolved

RTSandberg force-pushed the topic-printWhenWritingOutput branch from 6773f47 to 216781a Compare October 7, 2022 21:26

RTSandberg changed the title ~~[WIP] print when writing openPMD, Ascent, Sensei~~ [WIP] Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD Oct 7, 2022

RTSandberg force-pushed the topic-printWhenWritingOutput branch from fc43f11 to 7c94b2b Compare October 11, 2022 21:02

RTSandberg changed the title ~~[WIP] Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD~~ Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD Oct 11, 2022

RTSandberg added the component: boosted frame boosted frame components & logic label Oct 11, 2022

EZoni self-requested a review October 12, 2022 00:34

EZoni reviewed Oct 12, 2022

View reviewed changes

Regression/WarpX-tests.ini Show resolved Hide resolved

Examples/Physics_applications/laser_acceleration/inputs_2d_boost Show resolved Hide resolved

EZoni self-requested a review October 12, 2022 16:56

EZoni reviewed Oct 12, 2022

View reviewed changes

RTSandberg requested a review from EZoni October 14, 2022 16:54

RTSandberg force-pushed the topic-printWhenWritingOutput branch from b0b4e34 to b983072 Compare October 14, 2022 16:59

EZoni approved these changes Oct 14, 2022

View reviewed changes

EZoni requested a review from ax3l October 14, 2022 18:07

ax3l requested a review from RevathiJambunathan October 24, 2022 22:29

ax3l reviewed Oct 24, 2022

View reviewed changes

ax3l enabled auto-merge (squash) October 24, 2022 22:33

RTSandberg added 5 commits October 25, 2022 10:53

print when writing openPMD, Ascent, Sensei

703a427

remove unnecesssary variables, include min_digits

69b6db2

print snapshot id when writing btd

c29cdf9

fix ascent print

f4289aa

compile without warnings

7963faf

RTSandberg and others added 24 commits October 25, 2022 10:55

remove unnecesssary variables, include min_digits

b189f54

print snapshot id when writing btd

8f14b45

fix ascent print

24a4431

compile without warnings

a0da967

still working on Ascent

05cbe9d

still working Ascent

dac0827

Print when BTD buffer is flushed

fec201d

[pre-commit.ci] auto fixes from pre-commit.com hooks

b2e8a34

for more information, see https://pre-commit.ci

add warning message if BTD not full

1897bd7

adjust for CI, no in-situ vis BTD

88122bf

[pre-commit.ci] auto fixes from pre-commit.com hooks

5155d60

for more information, see https://pre-commit.ci

revert to correct plotfile naming

dae6dcd

change warning topic to BTD

73e9457

nicer format for print statements

bb5177c

extend examples to fill BTD

940ce8a

[pre-commit.ci] auto fixes from pre-commit.com hooks

c8d8e5f

for more information, see https://pre-commit.ci

Reset Checksums of BTD_ReducedSliceDiag

21a48aa

Upgrade CI Test LaserAccelerationBoost

a131a13

Apply suggestions from code review

6499937

Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>

improve BTD warning notes

cfb0a49

edit final step notes

4710ee6

[pre-commit.ci] auto fixes from pre-commit.com hooks

7bd1492

for more information, see https://pre-commit.ci

[pre-commit.ci] auto fixes from pre-commit.com hooks

61e0056

for more information, see https://pre-commit.ci

Fix formatting

4533efa

auto-merge was automatically disabled October 25, 2022 17:57
Head branch was pushed to by a user without write access

RTSandberg force-pushed the topic-printWhenWritingOutput branch from 4e279ee to 4533efa Compare October 25, 2022 17:57

EZoni enabled auto-merge (squash) October 25, 2022 18:05

EZoni merged commit e4c7354 into ECP-WarpX:development Oct 25, 2022

RTSandberg deleted the topic-printWhenWritingOutput branch October 25, 2022 20:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD #3424

Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD #3424

RTSandberg commented Sep 22, 2022 •

edited by EZoni

Loading

EZoni commented Sep 28, 2022

EZoni left a comment

EZoni left a comment

EZoni left a comment

EZoni commented Oct 21, 2022

ax3l Oct 24, 2022

Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD #3424

Diagnostics: print when writing openPMD, Ascent, Sensei and when writing BTD plotfile and openPMD #3424

Conversation

RTSandberg commented Sep 22, 2022 • edited by EZoni Loading

EZoni commented Sep 28, 2022

EZoni left a comment

Choose a reason for hiding this comment

EZoni left a comment

Choose a reason for hiding this comment

EZoni left a comment

Choose a reason for hiding this comment

EZoni commented Oct 21, 2022

ax3l Oct 24, 2022

Choose a reason for hiding this comment

RTSandberg commented Sep 22, 2022 •

edited by EZoni

Loading