Cleanup how fields_to_plot = none is handled #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ae0758 to
cc14c52
Compare
dpgrote
commented
Jul 8, 2022
| @@ -540,12 +540,8 @@ FullDiagnostics::InitializeBufferData (int i_buffer, int lev ) { | |||
| if (use_warpxba == false) dmap = amrex::DistributionMapping{ba}; | |||
| // Allocate output MultiFab for diagnostics. The data will be stored at cell-centers. | |||
| int ngrow = (m_format == "sensei" || m_format == "ascent") ? 1 : 0; | |||
| // The zero is hard-coded since the number of output buffers = 1 for FullDiagnostics | |||
There was a problem hiding this comment.
Note for reviewer - this comment was left over from previous changes and is no longer meaningful so was delete here for clean up.
|
Feel free to bump AMReX to the latest version in the current PR via this script: |
Via ``` ./Tools/Release/updateAMReX.py ```
ae7a95d to
864d441
Compare
|
I went ahead and pushed the AMReX update :) |
|
Thanks @ax3l! |
3 tasks
dpgrote
added a commit
to RemiLehe/WarpX
that referenced
this pull request
Jul 30, 2022
* For fields_to_plot=none, do allocation with ncomp=0 * Update AMReX Via ``` ./Tools/Release/updateAMReX.py ``` Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a change in AMReX that allows MultiFabs to be created with ncomp = 0. (AMReX PR #2873) This allows the handling the
fields_to_plot = noneto be cleaned up, removing theifchecks around the allocation and call toWriteToFile.This also fixes another issue that arose in PR #2419, that the plot files were not readable by Yt (because the Header file was not written out). With this PR, that is also fixed.
Once the version of AMReX that WarpX depends on is updated, I remove the WIP and this can be merged.