Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 22.05 #3076

Merged
merged 6 commits into from
May 3, 2022
Merged

Release 22.05 #3076

merged 6 commits into from
May 3, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented May 2, 2022

Prepare the May release of WarpX:

# update dependencies
./Tools/Release/updateAMReX.py
./Tools/Release/updatePICSAR.py
# bump version number
./Tools/Release/newVersion.sh

Following this workflow: https://warpx.readthedocs.io/en/latest/maintenance/release.html

@ax3l ax3l added component: documentation Docs, readme and manual component: third party Changes in WarpX that reflect a change in a third-party library labels May 2, 2022
@ax3l
Copy link
Member Author

ax3l commented May 2, 2022

Note: will close & re-open this PR (to trigger CI) once AMReX 22.05 is released :)

@ax3l ax3l requested a review from WeiqunZhang May 2, 2022 03:15
@WeiqunZhang
Copy link
Member

AMReX 22.05 has been released.

@WeiqunZhang WeiqunZhang closed this May 2, 2022
@WeiqunZhang WeiqunZhang reopened this May 2, 2022
@RemiLehe
Copy link
Member

RemiLehe commented May 2, 2022

@WeiqunZhang
It seems that the automated tests are failing for RZ electrostatic solves, with the following error:

Assertion `m_sigma[0] == 0._rt' failed, file "/tmp/ci/warpx/builddir/_deps/fetchedamrex-src/Src/LinearSolvers/MLMG/AMReX_MLEBNodeFDLaplacian.cpp", line 313, Msg: "r-direction sigma must be zero" !!!

I am guessing that this means we need to call linop.setSigma( in the RZ case and set the first component to 0.
I will go ahead and modify this PR accordingly.

@WeiqunZhang
Copy link
Member

Oh. That assertion is wrong. It should be == 1 not == 0.

@RemiLehe
Copy link
Member

RemiLehe commented May 2, 2022

Note that this minimal fix will then be cleaned up by this PR:

#3026

@RemiLehe
Copy link
Member

RemiLehe commented May 2, 2022

@WeiqunZhang Oh, ok. I guess this will be part of the next amrex release, correct?
For now, I will still set sigma to 0 for the RZ case.

@WeiqunZhang
Copy link
Member

OK. Maybe I will simply remove the assertion.

@ax3l ax3l enabled auto-merge (squash) May 2, 2022 21:39
@ax3l ax3l merged commit a7cf8a4 into ECP-WarpX:development May 3, 2022
@ax3l ax3l deleted the release-22.05 branch May 3, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Docs, readme and manual component: third party Changes in WarpX that reflect a change in a third-party library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants