Langmuir 2D Tests: Better Analysis Plots #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging f59b763 into f00682d - view on LGTM.com new alerts:
|
EZoni
commented
Mar 11, 2022
ax3l
approved these changes
Mar 11, 2022
dpgrote
approved these changes
Mar 12, 2022
This was referenced Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at some of the Langmuir 2D tests, I noticed that the plots that we produce with our analysis script could be slightly improved (see comparison below for the test
Langmuir_multi_2d_psatd_Vay_deposition; notable differences: size of colorbar, axis labels, axis ticks (physical extent instead of cell number)).Old plot:
New plot: