Fixing the computation of ECT Rho Field #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Merged
ax3l
reviewed
Feb 2, 2022
Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceSolver.H
Outdated
Show resolved
Hide resolved
RemiLehe
approved these changes
Feb 2, 2022
| } | ||
|
|
||
| #ifndef WARPX_DIM_RZ | ||
| void FiniteDifferenceSolver::EvolveRhoCartesianECT ( |
There was a problem hiding this comment.
The fact that this function was copied to a different file makes it difficult to see whether were any changes.
@lgiacome Could you confirm that there was no change in this function?
There was a problem hiding this comment.
Correct, there were no changes. It was just a copy-paste :)
EZoni
reviewed
Feb 2, 2022
Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceSolver.H
Outdated
Show resolved
Hide resolved
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
EZoni
approved these changes
Feb 3, 2022
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few fixes to the ECT solver.
Initially the 3D test in Examples/Tests/PEC failed when using the ECT solver instead of Yee.
This is the 1D plot of the field we would obtain with ECT:
While this is what we would have with Yee:
There were two issues:
In both cases the problem is that the ECTRho field was not recomputed correctly after the electric field was modified. In the second case the E field is modified by the initialisation and in the second case the E field is modified by the boundary conditions.
With this PR we add the missing calls to
EvolveRhoCartesianECTand we introduce the new functionEvolveECTRhofor consistency with the update of the other fields and in view of possible extensions of the ECT algorithm (e.g. RZ).With these changes the test passes also with the ECT algorithm and we retrieve the same results as with the Yee solver.