Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Div(B) Cleaning: Change Normalization of G #2429

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Div(B) Cleaning: Change Normalization of G #2429

merged 4 commits into from
Oct 21, 2021

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Oct 14, 2021 •
edited
Loading

This is simply including the factor of c squared (c2) in the normalization of the G field.

This normalization matches the one used for the corresponding equations in the PML (implemented in PMLPsatdAlgorithm.cpp), which is crucial when div(B) cleaning is used both in the valid domain and in the PML (development in progress).

To-do (for consistency):

  • Same change with FDTD;
  • Same change with RZ PSATD.

Let me know if you prefer that I fix the PML PSATD equations instead, leaving the normalization elsewhere as it is.

@EZoni EZoni added the component: spectral Spectral solvers (PSATD, IGF) label Oct 14, 2021
EZoni added a commit to EZoni/WarpX that referenced this pull request Oct 14, 2021
@EZoni
Include Fix of ECP-WarpX#2429 until Merged
3ded70f
@EZoni EZoni mentioned this pull request Oct 15, 2021
Merged
@EZoni EZoni changed the title PSATD with div(B) Cleaning: Change Normalization of G [WIP] PSATD with div(B) Cleaning: Change Normalization of G Oct 15, 2021
@EZoni EZoni changed the title [WIP] PSATD with div(B) Cleaning: Change Normalization of G [WIP] Div(B) Cleaning: Change Normalization of G Oct 16, 2021
EZoni
EZoni commented Oct 19, 2021
View reviewed changes
Regression/Checksum/benchmarks_json/divb_cleaning_3d.json
"G": 0.08248210392635753,
"G": 7.413121805692223e+15,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This large change is due to the factor c^2 (roughly 9e+16) of difference in the new normalization of G.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we don't see a similar change in the test pml_psatd_dive_divb_cleaning because that test uses G only in the PML (since div cleaning is not yet available in the valid domain with standard PSATD), hence G is not among the fields that are saved to output for the checksum benchmark.

@EZoni EZoni requested a review from RemiLehe October 19, 2021 17:47
@EZoni EZoni changed the title [WIP] Div(B) Cleaning: Change Normalization of G Div(B) Cleaning: Change Normalization of G Oct 19, 2021
@EZoni EZoni requested review from dpgrote and oshapoval October 19, 2021 23:47
@EZoni EZoni mentioned this pull request Oct 20, 2021
Closed
@RemiLehe RemiLehe merged commit 7d011e8 into ECP-WarpX:development Oct 21, 2021
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Nov 29, 2021
@EZoni @dpgrote
Div(B) Cleaning: Change Normalization of G (ECP-WarpX#2429)
5d05b71 
* PSATD with div(B) Cleaning: Change Normalization of G

* Use New Normalization also in RZ

* Use New Normalization also in FDTD

* Reset Benchmark of Test divb_cleaning_3d
RemiLehe pushed a commit that referenced this pull request Dec 2, 2021
@EZoni
div(E,B) Cleaning Options for PSATD (#2403)
3610edb 
* Implement div(E)/div(B) Cleaning with Standard PSATD

* Cleaning

* Update Benchmark

* Add Nodal Synchronization of F,G

* OneStep_multiJ: Nodal Syncs, Damp PML

* OneStep_multiJ: Push PSATD Fields in PML

* div Cleaning Defaults (Domain v. PML)

* Include Fix of #2429 until Merged

* Reset Benchmark of Langmuir_multi_psatd_div_cleaning

* Multi-J: Remove PML Support

* Include Fix of #2474 Until Merged

* Exchange All Guard Cells for F,G

* Fix Defaults

* Update Test, Reset Benchmark

* Fix Defaults

* Cleaning

* Default update_with_rho=1 if do_dive_cleaning=1

* Update CI Test pml_psatd_dive_divb_cleaning

* Replace Warning with Abort
roelof-groenewald added a commit to ModernElectron/WarpX that referenced this pull request Dec 3, 2021
@roelof-groenewald @ax3l
@EZoni @RemiLehe @lgiacome @KZhu-ME @peterscherpelz @dpgrote @PhilMiller @s9105947 @tropf @prkkumar
Update memaster (#110)
033b51e 
* Fix Init of Vector Members (ECP-WarpX#2595)

Fix default init of `Vector` member variables. The old construct
is not valid C++.

https://stackoverflow.com/a/11491003/2719194

* C++17: Work-Around NVCC gatherParticles (ECP-WarpX#2596)

The `noexcept` lambda does not compile in C++17 mode due to an NVCC compiler bug, at least in NVCC 11.3.109. Compiles in C++14 mode with the same compiler.

* requirements.txt - PICMI development version (ECP-WarpX#2588)

Document in `requirements.txt` on how to install a pre-release
version of PICMI.

* CONTRIBUTING: Update/Modernize (ECP-WarpX#2600)

* CONTRIBUTING: Update/Modernize

- Add GitHub account setup
- Add local git setup
- Modernize for CMake workflows

* Apply suggestions by Edoardo

Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>

* Replaced duplicated current deposition documentation (ECP-WarpX#2604)

* Throwing a warning if particle_shape>1 with EB (ECP-WarpX#2592)

* Aborting if particle_shape!=1 with EB

* Throw warning instead of aborting

* Checking at runtime if EB is initialized

* Added missing preprocessor directive

* Ignoring an unused variable

* Fix typo

* Improve style

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Fix segfault when importing _libwarpx without initializing WarpX (ECP-WarpX#2580)

* Added check for if warpx was initialized when calling finalize

* Renamed to be warpx_initialized

* Fixed reference to global variable

Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com>

* Changed global variable to member of libwarpx

* Fixed syntax errors

* Remove custom arg from argv to avoid parmparse error

Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com>

* Added parallel pragma to ApplyBoundaryConditions (ECP-WarpX#2612)

* Note that CCache 4.2 introduced large CUDA improvements (ECP-WarpX#2606)

* Dimensionality Docs: Default (ECP-WarpX#2609)

Just adds the note that 3D is the default geometry.

* AMReX: Weekly Update (ECP-WarpX#2613)

* MergeBuffersForPlotfile: Barrier (ECP-WarpX#2608)

Make sure that all MPI ranks are in sync, i.e., have closed the
files that they wrote, before trying to merge them.

* Fix installation location for libraries (ECP-WarpX#2583)

During configuration the installation location for libraries is given by
dumping the cmake variable `CMAKE_INSTALL_LIBDIR`.
This commit adjusts the installation of WarpX libraries (WarpX_LIB=ON)
to respect this setting.

Co-authored-by: Rolf Pfeffertal <tropf@users.noreply.github.com>

* Release 21.12 (ECP-WarpX#2614)

* AMReX: 21.12

* PICSAR: 21.12

* WarpX: 21.12

* div(E,B) Cleaning Options for PSATD (ECP-WarpX#2403)

* Implement div(E)/div(B) Cleaning with Standard PSATD

* Cleaning

* Update Benchmark

* Add Nodal Synchronization of F,G

* OneStep_multiJ: Nodal Syncs, Damp PML

* OneStep_multiJ: Push PSATD Fields in PML

* div Cleaning Defaults (Domain v. PML)

* Include Fix of ECP-WarpX#2429 until Merged

* Reset Benchmark of Langmuir_multi_psatd_div_cleaning

* Multi-J: Remove PML Support

* Include Fix of ECP-WarpX#2474 Until Merged

* Exchange All Guard Cells for F,G

* Fix Defaults

* Update Test, Reset Benchmark

* Fix Defaults

* Cleaning

* Default update_with_rho=1 if do_dive_cleaning=1

* Update CI Test pml_psatd_dive_divb_cleaning

* Replace Warning with Abort

* Add 2D Langmuir Test w/ MR & PSATD (ECP-WarpX#2605)

* Add 2D Langmuir Test w/ MR & PSATD

* Add Missing Compile String

* Fix out-of-bound in Inverse FFT of F,G (ECP-WarpX#2619)

* Mention that the potentail should be constant inside EB (ECP-WarpX#2618)

* Mention that the potentail should be constant inside EB

* Update text

* Replace AMREX_SPACEDIM: Boundary & Parallelization (ECP-WarpX#2620)

* AMREX_SPACEDIM : Boundary Conditions
* AMREX_SPACEDIM : Parallelization
* Fix compilation
* Update Source/Parallelization/WarpXComm_K.H

* Fix out-of-bound in the initialization of EB (ECP-WarpX#2607)

* Call FillBoundary when initializing EB

* Avoid out-of-bound

* Bug fix

* Apply suggestions from code review

* update version number

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Lorenzo Giacomel <47607756+lgiacome@users.noreply.github.com>
Co-authored-by: Kevin Z. Zhu <86268612+KZhu-ME@users.noreply.github.com>
Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com>
Co-authored-by: David Grote <grote1@llnl.gov>
Co-authored-by: Phil Miller <phil@intensecomputing.com>
Co-authored-by: s9105947 <80697868+s9105947@users.noreply.github.com>
Co-authored-by: Rolf Pfeffertal <tropf@users.noreply.github.com>
Co-authored-by: Prabhat Kumar <89051199+prkkumar@users.noreply.github.com>
@EZoni EZoni mentioned this pull request Oct 20, 2022
Merged
9 tasks
@EZoni EZoni deleted the G_normalize branch June 7, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiLehe RemiLehe RemiLehe approved these changes

@dpgrote dpgrote Awaiting requested review from dpgrote

@oshapoval oshapoval Awaiting requested review from oshapoval

Assignees
No one assigned
Labels
component: spectral Spectral solvers (PSATD, IGF)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EZoni @RemiLehe