GetPosition 2D3V: y=0 #2233
Merged
GetPosition 2D3V: y=0 #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2D3V, we currently assigned the y position a signaling NaN in `GetPosition`, so that it cannot be used accidentially in functions. When we call parser functions, this value is copied even if it is not used, raising the signaling NaN. Rethinking the strategy, we can write more general inputs files if we instead write a sensible default for `y` in 2D3V: `y=0`. So this PR changes the default, which also fixes the issue.
EZoni
approved these changes
Aug 25, 2021
atmyers
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2D3V, we currently assigned the y position a signaling NaN in
GetPosition, so that it cannot be used accidentially in functions.When we call parser functions, this value is copied even if it is not used, raising the signaling NaN: #2205
Rethinking the strategy, we can write more general inputs files if we instead write a sensible default for
yin 2D3V:y=0. So this PR changes the default, which also fixes the issue.