Do Not Fill Guard Cells with Inverse FFTs, Unless for Field Damping #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2021
Merged
3a14f40 to
a9799c5
Compare
0b014e8 to
2719831
Compare
|
@RemiLehe I suggest to have a look here before I update the benchmarks, because the failing tests on Azure will print out the relative errors of each failing benchmark. This will help us get an idea of which tests fail and how much they fail. So I will commit the update of the benchmarks after all CI checks have finished, following the last commit I just pushed (b85faab). |
NeilZaim
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
That looks good to me, thanks!
If we wanted to be more general, we could consider having a fill_guards_lo and a fill_guards_hi but I don't know if there are situations where that would be useful. (e.g., if there's a scenario where field_boundary_lo[dir] is Damped and field_boundary_hi[dir] isn't)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2035.
Description
I added a new static member to the WarpX class, the IntVect
fill_guards. It is anAMREX_SPACEDIM-dimensional vector of integers (0 or 1 should be the only allowed values), to control whether to fill the guard cells when performing inverse FFTs, independently along each direction. Whenfill_guards = 0in some direction, the full box used for the loop in the inverse FFT is shrinked by the number of guard cells in that direction.WarpX::fill_guardsis currently set to0in each direction, unless the direction is non-periodic and field damping is applied (e.g. with a moving window).