[min-PR] QED module: use function provided by PICSAR to calculate gamma factor for photons #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the PICSAR commit changes you made here have just been merged independently in |
Oh, I see! Anyway, I've just merged the development branch into my branch... |
EZoni
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside
BreitWheelerEngineWrapper.Hwe need to calculate the gamma factor for photons to decide if their optical depth changes.Indeed, if gamma < 2 the optical depth should not be evolved and pair generation should not take place (if pair production is called with gamma < 2, it leads to electrons and positrons having NaN as momentum components).
With this PR, gamma is calculated with a function provided by PICSAR. This ensures that the result is identical to what is calculated internally in PICSAR, preventing possible issues to due machine-precision errors.