Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup of RZ in collisions #1774

Merged
merged 4 commits into from
Mar 11, 2021
Merged

Minor cleanup of RZ in collisions #1774

merged 4 commits into from
Mar 11, 2021

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Mar 10, 2021 •
edited
Loading

This slightly simplifies the code by removing the need for a call to the ignore_unused function.

I also simplified the indentation, by using return statements in the ParallelFor construct.

@RemiLehe RemiLehe mentioned this pull request Mar 10, 2021
Closed
4 tasks
@ax3l ax3l added geometry: RZ axisymmetric 2D and quasi-3D cleaning Clean code, improve readability labels Mar 11, 2021
ax3l
ax3l approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both! 🎉

@ax3l ax3l self-assigned this Mar 11, 2021
@ax3l ax3l added the component: collisions Anything related to particle collisions label Mar 11, 2021
@ax3l ax3l merged commit b160cdd into ECP-WarpX:development Mar 11, 2021
@RemiLehe RemiLehe deleted the minor_cleanup branch May 4, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

@Yin-YinjianZhao Yin-YinjianZhao Yin-YinjianZhao approved these changes

Assignees

@ax3l ax3l

Labels
cleaning Clean code, improve readability component: collisions Anything related to particle collisions geometry: RZ axisymmetric 2D and quasi-3D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RemiLehe @ax3l @Yin-YinjianZhao