SYCL 2020/DPC++: C++17 #1375
Merged
SYCL 2020/DPC++: C++17 #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request C++17 in GNUmake for DPC++ builds. This is now required since we use MKL headers that are in C++17 and since SYCL 2020 and later rely on C++17 or newer. (In fact, `dpcpp` beta07 and newer already defaulted to C++17.) This updates the explicit GNUmake flag (request exactly one standard). The CMake flags in WarpX are "request C++14 or newer" and AMReX CMake files push those up to "request C++17 or newer" for DPC++.
9106f77 to
3c7e933
Compare
WeiqunZhang
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request C++17 in GNUmake for DPC++ builds. This is now required since we use MKL headers that are in C++17 and since SYCL 2020 and later rely on C++17 or newer. (In fact,
dpcppbeta07 and newer already defaulted to C++17.)This updates the explicit GNUmake flag (request exactly one standard).
The CMake flags in WarpX are "request C++14 or newer" and AMReX' CMake target pushes those up to "request C++17 or newer" for DPC++: AMReX-Codes/amrex#1402