Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat diversion node #327

Merged
merged 7 commits into from
Feb 21, 2025
Merged

Conversation

jmccreight
Copy link
Member

@jmccreight jmccreight commented Feb 14, 2025

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst or it's sub rsts?

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 87.35632% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (abd4b79) to head (b1e09ea).
Report is 43 commits behind head on develop.

Files with missing lines Patch % Lines
pywatershed/base/process.py 38.46% 8 Missing ⚠️
pywatershed/hydrology/source_sink_flow_node.py 95.38% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #327      +/-   ##
===========================================
+ Coverage    71.53%   71.93%   +0.40%     
===========================================
  Files           62       63       +1     
  Lines         8509     8635     +126     
===========================================
+ Hits          6087     6212     +125     
- Misses        2422     2423       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmccreight jmccreight merged commit 23f08a8 into EC-USGS:develop Feb 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant