Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corepack を利用する #974

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Corepack を利用する #974

merged 2 commits into from
Aug 13, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Aug 9, 2024

Corepack を利用することで、 yarn のインストールされていない環境でも yarn コマンドを実行するだけで、 yarn をインストールすることができる
https://yarnpkg.com/corepack
https://zenn.dev/teppeis/articles/2021-05-corepack

  • corepack は Node.js v14.19.0 以降では標準でバンドルされている
  • 自前で yarn をインストールしている環境は従来どおり利用可能

@nanasess nanasess enabled auto-merge August 9, 2024 16:08
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (9b77175) to head (b3f106e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #974   +/-   ##
=======================================
  Coverage   55.63%   55.63%           
=======================================
  Files          75       75           
  Lines        8917     8917           
=======================================
  Hits         4961     4961           
  Misses       3956     3956           
Flag Coverage Δ
tests 55.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess
Copy link
Contributor Author

yarn v3 or v4 を利用するかどうかは要検討(ご意見ください)

@nobuhiko
Copy link
Contributor

自分の環境ではyarnやめちゃいました

@nanasess nanasess merged commit 00bfbb8 into EC-CUBE:master Aug 13, 2024
90 checks passed
@nanasess nanasess deleted the use-corepack branch August 13, 2024 01:02
@nanasess
Copy link
Contributor Author

@nobuhiko いまだと pnpm とかがいいんですかね?

@nobuhiko
Copy link
Contributor

@nanasess 対して機能も使ってないしnpmでじゅうぶんなのかなーと思ってます。webpackは最近 exporse-loader を使ってちょっと最適化しました

@nanasess
Copy link
Contributor Author

@nanasess なるほどー。たしかに webpack と playwright を実行するくらいしか使ってないので npm で十分かもですね

@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants