PHP Warning 回避 #958
Merged
PHP Warning 回避 #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
==========================================
- Coverage 55.69% 55.69% -0.01%
==========================================
Files 75 75
Lines 8905 8906 +1
==========================================
Hits 4960 4960
- Misses 3945 3946 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nanasess
reviewed
Jul 22, 2024
| @@ -63,8 +63,7 @@ public function process() | |||
| public function action() | |||
| { | |||
| // 基本情報を渡す | |||
| $objSiteInfo = SC_Helper_DB_Ex::sfGetBasisData(); | |||
There was a problem hiding this comment.
変更前の以下コードだったら、$this->arrInfo は null だったはずなので、いまさら $this->arrInfo = SC_Helper_DB_Ex::sfGetBasisData(); する必要も無いだろうという観点でしょうか?
$objSiteInfo = SC_Helper_DB_Ex::sfGetBasisData();
$this->arrInfo = $objSiteInfo->data;
確かに無さそうですね。
$ fgrep -r arrInfo --include='recommend.tpl' | wc -l
0
消しましょうか?
There was a problem hiding this comment.
対応しました。5fbce349913be3cc270f7340dd06eeb0a3a10dae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 で見かけた Warning を回避する。
root_parent_idの配列要素追加の右辺値で Warning が発生していた。当該プロパティは2007年に追加されたが、2008年にはテンプレートから参照されなくなっているため、削除して良いと判断している。