-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#783 #784 CSS改善 (PC) #804
#783 #784 CSS改善 (PC) #804
Conversation
- CSS Nesting Module を使った実装 EC-CUBE#783 - CSS ファイルをまとめる EC-CUBE#784 ``` cat \ html/user_data/packages/default/css/reset.css \ html/user_data/packages/default/css/common.css \ html/user_data/packages/default/css/contents.css \ html/user_data/packages/default/css/table.css \ html/user_data/packages/default/css/bloc.css \ html/user_data/packages/default/css/bloc_alpha.css \ html/user_data/packages/default/css/popup.css \ html/user_data/packages/default/css/print.css \ | sass-convert --indent=4 --from=css --to=scss \ > html/user_data/packages/default/style.css ```
目視で気になった点を調整した。
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
=======================================
Coverage 55.38% 55.38%
=======================================
Files 75 75
Lines 8908 8908
=======================================
Hits 4934 4934
Misses 3974 3974
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
削除されたファイルを参照しているが未使用と思われるファイルを削除する。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bluestylejp-toya 氏提供のテンプレートを取り込み。 - data/class/SC_Display.php data/Smarty/templates/admin/design/subnavi.tpl の対応に関しては、議論が必要と認識している。 - #804 適用前でブランチを切った。master マージに辺り、#804 の再適用が必要。
No description provided.