Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADMIN_DIRを変更するとパスが*/adminのままになる #1179

Closed
wants to merge 1 commit into from

Conversation

clicktx
Copy link
Contributor

@clicktx clicktx commented Feb 16, 2025

$this->assign('TPL_URLPATH', ROOT_URLPATH.USER_DIR.USER_PACKAGE_DIR.'admin/');

TPL_URLPATHのパスがハードコーディングされているため、特定の環境や変更により、パスが正しく読み込まれない箇所が発生する可能性があります。

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.07%. Comparing base (f52f6e2) to head (db3f5ee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   50.07%   50.07%           
=======================================
  Files          82       82           
  Lines       10583    10583           
=======================================
  Hits         5299     5299           
  Misses       5284     5284           
Flag Coverage Δ
tests 50.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess
Copy link
Contributor

@clicktx ここは html/user_data/packages 以下のテンプレート名が入る箇所で、 管理画面は admin のまま固定だと思われます。
ADMIN_DIR にしてしまうと、 CSS や JavaScript ファイルが読めなくなってしまいそうですがいかがでしょうか?

@clicktx
Copy link
Contributor Author

clicktx commented Feb 18, 2025

@nanasess

html/user_data/packages 以下のテンプレート名が入る箇所で、

あぁ、勘違いしていました。
admin/ 以外に変更する場合は html/admin を変更するのみなのですね。
/html/user_data/packages/admin は変更する必要が無いディレクトリということでした。。。申し訳ないです。

お手数おかけしました。。。

@clicktx clicktx closed this Feb 18, 2025
@clicktx clicktx reopened this Feb 18, 2025
@clicktx clicktx closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants