Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery-ui を eccube.js にバンドルする #1163

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jan 28, 2025

  • jquery-ui 1.14.x へアップグレード
  • jquery-ui.sortable({ appendTo: 'body' }) だとドラッグ中の背景色が消失してしまうため、 parent に変更
  • お気に入りのツールチップが正常に動作することを確認
    image
  • レイアウト管理画面がドラッグ&ドロップで正常に動作することを確認
    image

- jquery-ui.sortable({ appendTo: 'body' }) だとドラッグ中の背景色が消失してしまうため、 parent に変更
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.05%. Comparing base (55648f6) to head (f75da29).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   50.05%   50.05%           
=======================================
  Files          82       82           
  Lines       10580    10580           
=======================================
  Hits         5296     5296           
  Misses       5284     5284           
Flag Coverage Δ
tests 50.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanako-kina kanako-kina merged commit 68903b3 into EC-CUBE:master Jan 29, 2025
108 checks passed
@nanasess nanasess added this to the 2.25 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants