Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SC_Response_Ex #1147

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add SC_Response_Ex #1147

merged 2 commits into from
Jan 16, 2025

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess added this to the 2.18(仮) milestone Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.05%. Comparing base (522048a) to head (a1ad737).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1147   +/-   ##
=======================================
  Coverage   50.05%   50.05%           
=======================================
  Files          82       82           
  Lines       10580    10580           
=======================================
  Hits         5296     5296           
  Misses       5284     5284           
Flag Coverage Δ
tests 50.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seasoftjapan seasoftjapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require_once DATA_REALDIR.'class_extends/SC_Response_Ex.php'; で発生した例外が回避釣れることを確認した。
require_once DATA_REALDIR.'class_extends/SC_Response_Ex.php'; の有無に関わらず動作することを確認した。

@nanasess nanasess enabled auto-merge January 16, 2025 06:24
@nanasess nanasess merged commit 55648f6 into EC-CUBE:master Jan 16, 2025
108 checks passed
@nanasess nanasess deleted the extends-compartibility branch January 16, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants