Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC_Fpdf::setOrderData() Fatal error #1135 #1144

Merged
merged 3 commits into from
Jan 16, 2025
Merged

SC_Fpdf::setOrderData() Fatal error #1135 #1144

merged 3 commits into from
Jan 16, 2025

Conversation

seasoftjapan
Copy link
Contributor

fixed #1135

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 49.93%. Comparing base (26f7a7e) to head (60fa28d).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
data/class/SC_Fpdf.php 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
- Coverage   49.94%   49.93%   -0.01%     
==========================================
  Files          82       82              
  Lines       10480    10482       +2     
==========================================
  Hits         5234     5234              
- Misses       5246     5248       +2     
Flag Coverage Δ
tests 49.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

変数定義を外に出す。
@nanasess nanasess added this to the 2.18(仮) milestone Jan 16, 2025
@nanasess nanasess enabled auto-merge January 16, 2025 05:37
@nanasess nanasess merged commit 1ffd347 into master Jan 16, 2025
211 of 213 checks passed
@seasoftjapan seasoftjapan deleted the seasoft-1135 branch January 16, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SC_Fpdf::setOrderData() Fatal error
3 participants