Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

削除済みメンバー名義でログインされる場合があるのを修正 #1106

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

nanasess
Copy link
Contributor

Fixes #929

@nanasess
Copy link
Contributor Author

テストを書くのは難しそう。E2Eテストでログイン処理できていればOKとする

@nanasess nanasess added this to the 2.18(仮) milestone Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.94%. Comparing base (a248cbd) to head (3dc604c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   50.94%   50.94%           
=======================================
  Files          80       80           
  Lines       10256    10256           
=======================================
  Hits         5225     5225           
  Misses       5031     5031           
Flag Coverage Δ
tests 50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess merged commit 23e9e54 into EC-CUBE:master Dec 24, 2024
108 checks passed
@nanasess nanasess deleted the fix-lfDoLogin branch December 24, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

削除済みメンバー名義でログインされることがある
2 participants