Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テンプレートの上の乗算を直感的に。sfMultiply ではなく演算子で行う。 #1078

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

seasoftjapan
Copy link
Contributor

実装当時は、変数出力タグ内での演算に関して制約が厳しく、sfMultiply を使ってしのいでいたと理解している。

@seasoftjapan seasoftjapan added this to the 2.18(仮) milestone Dec 16, 2024
@seasoftjapan seasoftjapan self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.67%. Comparing base (c2247d0) to head (0dd5f76).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   51.67%   51.67%           
=======================================
  Files          80       80           
  Lines       10224    10224           
=======================================
  Hits         5283     5283           
  Misses       4941     4941           
Flag Coverage Δ
tests 51.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seasoftjapan seasoftjapan merged commit f036a53 into master Dec 16, 2024
212 checks passed
@seasoftjapan seasoftjapan deleted the seasoft-no_sfMultiply branch December 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants