Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ファイル管理でuser_data配下が削除される不具合修正 #1067

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

nanasess
Copy link
Contributor

fixes #682
連続リロードは playwright でテストできないため、E2Eテストは作成できなさそう。
#682 にある手順で user_data 配下が削除されないことを確認

@nanasess nanasess enabled auto-merge November 25, 2024 02:17
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.67%. Comparing base (90bb24a) to head (8744cd6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1067   +/-   ##
=======================================
  Coverage   51.67%   51.67%           
=======================================
  Files          80       80           
  Lines       10224    10224           
=======================================
  Hits         5283     5283           
  Misses       4941     4941           
Flag Coverage Δ
tests 51.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess merged commit 3e6abcb into EC-CUBE:master Dec 11, 2024
107 checks passed
@nanasess nanasess deleted the fix-user_data-delete branch December 11, 2024 13:38
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ファイル管理でuser_data配下が削除される不具合
2 participants