Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarty の Warning を抑制する #1058

Merged
merged 7 commits into from
Dec 23, 2024
Merged

Conversation

nanasess
Copy link
Contributor

refs #1045

  • muteUndefinedOrNullWarnings() で Smarty の Warning を抑制する
  • Warning の発生状況を確認するため、 data/logs 以下のログを常に保存するよう修正

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.70%. Comparing base (c2b3853) to head (dc7a677).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1058   +/-   ##
=======================================
  Coverage   51.70%   51.70%           
=======================================
  Files          80       80           
  Lines       10222    10223    +1     
=======================================
+ Hits         5285     5286    +1     
  Misses       4937     4937           
Flag Coverage Δ
tests 51.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess force-pushed the surpress-warning branch 6 times, most recently from 76aefc6 to 4183a07 Compare December 13, 2024 08:22
@nanasess nanasess mentioned this pull request Dec 13, 2024
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
@nanasess nanasess merged commit 320b42e into EC-CUBE:master Dec 23, 2024
108 checks passed
@nanasess nanasess deleted the surpress-warning branch December 23, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants