Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ソース整形 配列末尾のカンマと閉じ括弧を改行する #1017

Closed
seasoftjapan opened this issue Oct 2, 2024 · 0 comments · Fixed by #1050
Closed

ソース整形 配列末尾のカンマと閉じ括弧を改行する #1017

seasoftjapan opened this issue Oct 2, 2024 · 0 comments · Fixed by #1050
Assignees
@seasoftjapan
Labels
enhancement
Milestone
2.25

Comments

@seasoftjapan
Copy link
Contributor

#996 で、配列の末尾が , ] となった箇所を ,\n] の要領で改行する。
実際には、妥当なインデントに調整する必要がある。

関連: #996 (comment)
@seasoftjapan seasoftjapan added this to the 2.17.3 milestone Oct 2, 2024
@seasoftjapan seasoftjapan self-assigned this Oct 2, 2024
@seasoftjapan seasoftjapan mentioned this issue Oct 2, 2024
Merged
seasoftjapan added a commit that referenced this issue Nov 3, 2024
@seasoftjapan
ソース整形 配列末尾のカンマと閉じ括弧を改行する #1017
a363124 
- 手打ちで改行を追加。
- VSCode で整形。
- 関数呼び出しで、複数の引数の一部で可読性が悪い箇所は、一旦変数に収めた。
- 一次元配列はケツカンマを削除して1行に収めた。
- php-cs-fixer 実行。
@seasoftjapan seasoftjapan mentioned this issue Nov 3, 2024
Merged
seasoftjapan added a commit that referenced this issue Nov 12, 2024
@seasoftjapan
Merge pull request #1050 from EC-CUBE/seasoft-1017
6d133f4 
ソース整形 配列末尾のカンマと閉じ括弧を改行する #1017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seasoftjapan seasoftjapan

Labels
enhancement
Projects
None yet
Milestone
2.25
Development

Successfully merging a pull request may close this issue.

ソース整形 配列末尾のカンマと閉じ括弧を改行する #1017 EC-CUBE/ec-cube2
1 participant
@seasoftjapan